chore(ci): switch to rhdh version 2.0 - #3267
Conversation
Signed-off-by: Jan Richter <jrichter@redhat.com>
|
|
/test e2e-ocp-helm-nightly |
|
🤖 Finished Review · ✅ Success · Started 11:38 AM UTC · Completed 11:42 AM UTC Commit: |
ReviewVerdict: Comment — one medium-severity finding; non-blocking but should be addressed before merge. SummaryThis PR updates
Findings⚠ [medium] Hardcoded personal fork reference removes env var overrideFile: The
The PR body ("let's first check if the tests run properly") suggests this is intentionally exploratory. Before merging, this line should be reverted to the env-var pattern, or the corresponding changes should be upstreamed to the official Suggested remediation: Revert line 82 to |
| E2E_TEST_UTILS_VERSION="${E2E_TEST_UTILS_VERSION:-}" | ||
| # Git ref for e2e-test-utils: "owner/repo#branch" — clones and sets E2E_TEST_UTILS_PATH | ||
| E2E_TEST_UTILS_GIT_REF="${E2E_TEST_UTILS_GIT_REF:-}" | ||
| E2E_TEST_UTILS_GIT_REF="jrichter1/rhdh-e2e-test-utils#dpdy-quay" |
There was a problem hiding this comment.
[medium] correctness
E2E_TEST_UTILS_GIT_REF is hardcoded to a personal fork (jrichter1/rhdh-e2e-test-utils#dpdy-quay), removing the environment variable override and pointing all E2E runs (including nightly CI) to a personal fork branch that could be rebased, force-pushed, or deleted at any time.
Suggested fix: Revert to E2E_TEST_UTILS_GIT_REF="${E2E_TEST_UTILS_GIT_REF:-}" before merge. If the dpdy-quay branch changes are needed for RHDH 2.0, upstream them to redhat-developer/rhdh-e2e-test-utils first and reference the official repo or pin a published npm version.
❌ Failed Nightly E2E TestsPlatform: ocp 4.20 | RHDH Version: 1.11 | Duration: 41m 22s |
|
@jrichter1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



let's first check if the tests run properly