Skip to content

chore(ci): switch to rhdh version 2.0 - #3267

Open
jrichter1 wants to merge 1 commit into
redhat-developer:mainfrom
jrichter1:ci-rhdh-2
Open

chore(ci): switch to rhdh version 2.0#3267
jrichter1 wants to merge 1 commit into
redhat-developer:mainfrom
jrichter1:ci-rhdh-2

Conversation

@jrichter1

Copy link
Copy Markdown
Member

let's first check if the tests run properly

Signed-off-by: Jan Richter <jrichter@redhat.com>
@jrichter1
jrichter1 requested review from a team, gashcrumb and kadel as code owners August 14, 2026 11:38
@sonarqubecloud

Copy link
Copy Markdown

@jrichter1

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm-nightly

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 14, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 11:38 AM UTC · Completed 11:42 AM UTC

Commit: f854850 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review

Verdict: Comment — one medium-severity finding; non-blocking but should be addressed before merge.

Summary

This PR updates run-e2e.sh with two changes:

  1. RHDH version upgrade (1.11-57-CI2.0) ✅ — Moves from a CI-specific workaround version (pinned to avoid RHDHBUGS-3515) to the proper 2.0 release. This is appropriate for the main branch and removes the now-obsolete workaround comment. No concerns.

  2. Hardcoded personal fork for e2e-test-utils ⚠ — E2E_TEST_UTILS_GIT_REF is changed from an overridable env var (${E2E_TEST_UTILS_GIT_REF:-}) to a hardcoded personal fork reference (jrichter1/rhdh-e2e-test-utils#dpdy-quay). This is flagged below.

Findings

⚠ [medium] Hardcoded personal fork reference removes env var override

File: run-e2e.sh, line 82

The E2E_TEST_UTILS_GIT_REF variable is hardcoded to jrichter1/rhdh-e2e-test-utils#dpdy-quay, which:

  • Removes the environment variable override. The original pattern ${E2E_TEST_UTILS_GIT_REF:-} allowed CI and developers to set this externally. The hardcoded value ignores any E2E_TEST_UTILS_GIT_REF env var.
  • Points all E2E runs to a personal fork branch. If merged, every invocation of run-e2e.sh (including nightly CI) would git clone from jrichter1/rhdh-e2e-test-utils on the dpdy-quay branch rather than using the published npm package.
  • Creates a fragile dependency. The fork branch could be rebased, force-pushed, or deleted, breaking all E2E runs with no warning.

The PR body ("let's first check if the tests run properly") suggests this is intentionally exploratory. Before merging, this line should be reverted to the env-var pattern, or the corresponding changes should be upstreamed to the official redhat-developer/rhdh-e2e-test-utils repo and referenced by a published version.

Suggested remediation: Revert line 82 to E2E_TEST_UTILS_GIT_REF="${E2E_TEST_UTILS_GIT_REF:-}" before merge. If the dpdy-quay branch changes are needed for RHDH 2.0 compatibility, upstream them first and then either pin the npm version (E2E_TEST_UTILS_VERSION) or reference the official repo's branch.

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread run-e2e.sh
E2E_TEST_UTILS_VERSION="${E2E_TEST_UTILS_VERSION:-}"
# Git ref for e2e-test-utils: "owner/repo#branch" — clones and sets E2E_TEST_UTILS_PATH
E2E_TEST_UTILS_GIT_REF="${E2E_TEST_UTILS_GIT_REF:-}"
E2E_TEST_UTILS_GIT_REF="jrichter1/rhdh-e2e-test-utils#dpdy-quay"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] correctness

E2E_TEST_UTILS_GIT_REF is hardcoded to a personal fork (jrichter1/rhdh-e2e-test-utils#dpdy-quay), removing the environment variable override and pointing all E2E runs (including nightly CI) to a personal fork branch that could be rebased, force-pushed, or deleted at any time.

Suggested fix: Revert to E2E_TEST_UTILS_GIT_REF="${E2E_TEST_UTILS_GIT_REF:-}" before merge. If the dpdy-quay branch changes are needed for RHDH 2.0, upstream them to redhat-developer/rhdh-e2e-test-utils first and reference the official repo or pin a published npm version.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 14, 2026
@rhdh-test-bot

Copy link
Copy Markdown

❌ Failed Nightly E2E Tests

Platform: ocp 4.20 | RHDH Version: 1.11 | Duration: 41m 22s
Passed: 159 | Failed: 19 | Flaky: 0 | Skipped: 97
Playwright Report | Build Log | Logs | Artifacts

@openshift-ci

openshift-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown

@jrichter1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm-nightly f854850 link false /test e2e-ocp-helm-nightly

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@github-actions github-actions Bot added the non-workspace-changes PR changes files outside workspace directories label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-workspace-changes PR changes files outside workspace directories requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants