Tradeoff analysis#121
Draft
maryamtahhan wants to merge 3 commits into
Draft
Conversation
Adds new Streamlit page with GPU-style performance charts showing throughput/core vs latency and throughput/core vs interactivity tradeoffs. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
…nce charts - Add interactive toggles: Log Scale, Optimal Only, Show Concurrency Labels - Simplify legend text to "Platform | Cores" format (detailed info in hover) - Add optional concurrency labels on data points - Implement Pareto-optimal point filtering - Reduce legend width from 400px to 250px - Add concurrency to hover tooltip for all points Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
- Remove managed-only filter to support both managed and external tests - Add mode selector when both test types are present - Handle tests without core count data (external endpoints) - Dynamically adjust chart labels and metrics based on data availability - Add vllm_endpoint_url and model_source to data loader - Filter out core=0 from selection unless that's all available - Use raw throughput when per-core data unavailable - Skip groups with no valid data in charts This enables the dashboard to show interactivity metrics for external vLLM CPU endpoints with high concurrency (e.g., 160 users). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Maryam Tahhan <mtahhan@redhat.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.