Add kit directory validation during installation#345
Closed
sayalibhavsar wants to merge 2 commits intoredhat-performance:mainfrom
Closed
Add kit directory validation during installation#345sayalibhavsar wants to merge 2 commits intoredhat-performance:mainfrom
sayalibhavsar wants to merge 2 commits intoredhat-performance:mainfrom
Conversation
Contributor
Author
|
dvalinrh
requested changes
Jan 20, 2026
Contributor
dvalinrh
left a comment
There was a problem hiding this comment.
Is there a reason this is done with embedded python instead of simply using bash?
I do not want to go this way unless, required as it adds complication.
Contributor
Author
|
Changing mistaken python bit back to bash and testing BEFORE: AFTER: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds inline validation to install.sh that checks for missing kit files/directories specified in config templates and displays clear warnings during installation.
Before/After Comparison
Before: Installation completed silently even if required kits were missing, causing wrappers to fail later without clear indication why.
After: Installation displays a formatted warning listing all missing kits with their paths and guidance on how to resolve the issue.
Documentation Check
No documentation updates needed as this is a non-blocking warning feature that enhances existing installation behavior without changing user workflows.
Clerical Stuff
This closes #323
Relates to JIRA: RPOPC-700