Skip to content

Fix hard code of failing timeout #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

trend-shino-wu
Copy link

  1. if not set failing time limit, default is 15 seconds.

trend-shino-wu and others added 2 commits February 24, 2024 00:51
1. if not set failing time limit, default is 15 seconds.
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trend-shino-wu thank you for the contribution! Do you think the option can be named something like "FailingTimeI Seconds" to note that it should hold the amount of seconds. Also, please add tests and document the new option. Let me know when you are ready for final review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants