Add tracing hooks for existing connections #3432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the redis/go-redis library would call newTracingHook with no connString as default tracing, but that was recently removed in 9.8.0 which has caused our clients to lose oteltracing if connections are created before tracing can be instrumented.
|
Hello @AllanGuigou can you please cleanup the PRs, I can see two opened and the build is failing for both. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
InstruementTracingwould callnewTracingHookwith no connString as a default tracing hook, but that was recently removed in v9.8.0 which has caused our clients to lose tracing if connections are created before tracing can be instrumented. In #3433, I've reverted the change to remove the default tracing hook, but a potential solution would be to useForEachShardto create tracing hooks for any existing connections. This is a breaking change since it requires context, open to feedback if this PR should be moved forward instead of the revert.