-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add Query Builder for RediSearch commands #3436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add search module builders and tests * Add tests
Hey @ofekshenawa, thank you for this contribution. @htemelski-redis and I will review it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think it will make more sense to have New*Builder
constructors, to not to the user that the return value will be a builder that they can use to build the command. Where there are Actions
, we can either have one method per action or an Action
method to set it. Letting you decide. I am maybe leaning towards the methods per actions, whatever you decide let's keep it consistent across all builders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added couple of comments suggestion. Let's mark this as experimental and let the community provide feedback on the builders
Co-authored-by: Nedyalko Dyakov <[email protected]>
Co-authored-by: Nedyalko Dyakov <[email protected]>
Co-authored-by: Nedyalko Dyakov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets ship it and see what the community have to say 🚀
A query API builder pattern for RediSearch commands in go-redis, providing a more intuitive and type safe way to construct complex search queries and operations.
Features Added
Implementation Details