Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A demo of redis version tag proposal #3473

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

cjx-zar
Copy link

@cjx-zar cjx-zar commented Jun 20, 2023

This is a demo for annotating the compatible Redis version of the test cases in SetCommandsTest. #3471

In RedisType, we can define all compatible Redis versions. Then we use "@EnabledOnRedis" to specify that certain test cases can only be run on their compatible Redis versions.

When testing, we can use "mvn -Dredisversion=redis_xx" to set the version of Redis.

For example, in SetCommandsTest, Redis 6.0 does not support "sintercard", "sinterstore", and "smismember" commands, and we can skip these cases using "mvn -Dredisversion=redis_6".

@sazzad16
Copy link
Collaborator

@cjx-zar Thank you for your interest in improving Jedis tests.

It'd take quite some time for me to review. Please keep some patience until someone else reviews or I come back. Thanks again.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 5.03% and project coverage change: -65.44 ⚠️

Comparison is base (7331a7b) 71.30% compared to head (e70cfe9) 5.87%.

❗ Current head e70cfe9 differs from pull request most recent head 47c00aa. Consider uploading reports for the commit 47c00aa to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #3473       +/-   ##
============================================
- Coverage     71.30%   5.87%   -65.44%     
+ Complexity     4745     251     -4494     
============================================
  Files           275     277        +2     
  Lines         14740   14841      +101     
  Branches        990    1017       +27     
============================================
- Hits          10511     872     -9639     
- Misses         3800   13903    +10103     
+ Partials        429      66      -363     
Impacted Files Coverage Δ
src/main/java/redis/clients/jedis/Jedis.java 4.71% <0.00%> (-80.61%) ⬇️
...va/redis/clients/jedis/JedisShardedPubSubBase.java 0.00% <ø> (-70.91%) ⬇️
src/main/java/redis/clients/jedis/Module.java 0.00% <ø> (-33.34%) ⬇️
...ava/redis/clients/jedis/MultiNodePipelineBase.java 0.00% <0.00%> (-72.59%) ⬇️
...rc/main/java/redis/clients/jedis/UnifiedJedis.java 0.00% <0.00%> (-74.38%) ⬇️
...ients/jedis/json/commands/RedisJsonV1Commands.java 0.00% <0.00%> (ø)
...dis/json/commands/RedisJsonV1PipelineCommands.java 0.00% <0.00%> (ø)
...ients/jedis/json/commands/RedisJsonV2Commands.java 0.00% <0.00%> (ø)
...dis/json/commands/RedisJsonV2PipelineCommands.java 0.00% <0.00%> (ø)
...dis/clients/jedis/resps/AccessControlLogEntry.java 0.00% <ø> (-87.10%) ⬇️
... and 16 more

... and 222 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chenshi5012
Copy link
Contributor

should jedis compatible with multiple redis versions(5.x,6.x,7.x ) with one version? acturally, i meet some compatible issue whille upgrade redis from 5.x->6.x. add more compile option seems good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants