-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A demo of redis version tag proposal #3473
base: master
Are you sure you want to change the base?
Conversation
@cjx-zar Thank you for your interest in improving Jedis tests. It'd take quite some time for me to review. Please keep some patience until someone else reviews or I come back. Thanks again. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #3473 +/- ##
============================================
- Coverage 71.30% 5.87% -65.44%
+ Complexity 4745 251 -4494
============================================
Files 275 277 +2
Lines 14740 14841 +101
Branches 990 1017 +27
============================================
- Hits 10511 872 -9639
- Misses 3800 13903 +10103
+ Partials 429 66 -363
☔ View full report in Codecov by Sentry. |
should jedis compatible with multiple redis versions(5.x,6.x,7.x ) with one version? acturally, i meet some compatible issue whille upgrade redis from 5.x->6.x. add more compile option seems good. |
This is a demo for annotating the compatible Redis version of the test cases in SetCommandsTest. #3471
In RedisType, we can define all compatible Redis versions. Then we use "@EnabledOnRedis" to specify that certain test cases can only be run on their compatible Redis versions.
When testing, we can use "mvn -Dredisversion=redis_xx" to set the version of Redis.
For example, in SetCommandsTest, Redis 6.0 does not support "sintercard", "sinterstore", and "smismember" commands, and we can skip these cases using "mvn -Dredisversion=redis_6".