Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for vector search INT8/UINT8 types #4091

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Feb 18, 2025

Adding test to verify support for new vector types INT8/UINT8 added to RediSearch

@ggivo ggivo force-pushed the topic/vector-search-int8-tests branch from 49e8405 to de6e513 Compare February 18, 2025 12:30
@ggivo ggivo requested review from tishun, atakavci and uglide February 18, 2025 17:11
Copy link
Contributor

@atakavci atakavci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
is this complies with formatting already? how about making line length 120

@ggivo
Copy link
Contributor Author

ggivo commented Feb 19, 2025

LGTM ! is this complies with formatting already? how about making line length 120

Initially, I formatted the complete files, but it became unreadable (actual change mixed with formatting). In the end, I formatted only the new code. I think we should review the formatting approach.
I am fine with making the line 120

@ggivo ggivo removed the request for review from tishun February 19, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants