Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stale issue workflow #4101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update stale issue workflow #4101

wants to merge 1 commit into from

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Feb 25, 2025 •
edited
Loading

  • Mark the Issue as stale only if marked with waiting-for-feedback
  • Do not mark Issue/PR as stale if marked with feedback-provided
  • Do not mark the Issue/PR as stale if assigned to a milestone

@ggivo
Update stale issue workflow
a7dfcb2 
  - Mark issue as stale only if marked with waiting-for-feedback
  - Do not mark issue/PR as stale if mareked with feedback-provided
  - Do not mark issue as stale if assigned to milestone
@ggivo ggivo requested review from uglide, tishun and atakavci February 25, 2025 19:47
atakavci
atakavci reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@atakavci atakavci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think waiting a year on an issue without labels waiting-for-feedback or waiting-for-triage is good enough reason to close. Are we confident with the exempt rules ?

@ggivo
Copy link
Contributor Author

ggivo commented Feb 27, 2025 •
edited
Loading

i think waiting a year on an issue without labels waiting-for-feedback or waiting-for-triage is good enough reason to close. Are we confident with the exempt rules ?
@atakavci
The issue is that 'stale' rule was introduced a year ago, and since now it is over a year are marked stale and scheduled for removal. There are number of issue which wait for team action but are still marked as stale l. If we remove the stale tag manually in 30 days, it is again marked as stale and will need to be reviewed constantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atakavci atakavci atakavci left review comments

@uglide uglide Awaiting requested review from uglide

@tishun tishun Awaiting requested review from tishun

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggivo @atakavci