Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic documention for TBA support with some examples #4102

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

atakavci
Copy link
Contributor

Added some snippets for both generic usage and specific to EntraID.
Not sure about demonstrating advanced usage and scenarios here, i guess they should reside in official guide (which is in progress as well; #1166 ) .

@atakavci atakavci requested review from uglide and ggivo February 26, 2025 12:39
@atakavci atakavci self-assigned this Feb 26, 2025
uglide
uglide previously approved these changes Feb 26, 2025
Copy link
Contributor

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small suggestion on wording

Co-authored-by: Igor Malinovskiy <[email protected]>
```java
...
TokenAuthConfig tokenAuthConfig = EntraIDTokenAuthConfigBuilder.builder()
.expirationRefreshRatio(0.00002F)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit aggressive for the default example value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right 👍

Copy link
Contributor

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atakavci atakavci marked this pull request as ready for review February 27, 2025 10:36
@atakavci atakavci merged commit 5d8f869 into redis:master Feb 27, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants