Add LREM command support for removing list elements by value #38
Conversation
nishanthp
changed the title
|
I was not sure how to add reviewers, so tagging you to review the PR mortensi. Thank you! |
|
Thanks @nishanthp, we are looking at restructuring the toolset, and eventually reduce the number of exposed tools. As soon as we move forward, we'll review the PR and work on it. Thanks for contributing, I will keep you posted! |
|
Thanks @mortensi for the update! Looking forward to collaborating with you as things progress. |
src/tools/list.py
Outdated
| async def lrem(name: str, count: int, element: FieldT) -> str: | ||
| """Remove elements from a Redis list. | ||
| Args: | ||
| name: The name of the list | ||
| count: Number of elements to remove (0 = all, positive = from head, negative = from tail) | ||
| element: The element value to remove | ||
| Returns: | ||
| A string indicating the number of elements removed. | ||
| """ | ||
| try: | ||
| r = RedisConnectionManager.get_connection() | ||
| removed_count = r.lrem(name, count, element) | ||
|
|
||
| if removed_count == 0: | ||
| return f"Element '{element}' not found in list '{name}' or list does not exist." | ||
| else: | ||
| return f"Removed {removed_count} occurrence(s) of '{element}' from list '{name}'." | ||
|
|
||
| except RedisError as e: | ||
| return f"Error removing element from list '{name}': {str(e)}" |
There was a problem hiding this comment.
This tool needs to be covered by unit tests (see test_list.py) for reference.
There was a problem hiding this comment.
I have added the test cases for lrem method. Please see the below screenshot for details.
There was a problem hiding this comment.
Thanks for adding the tests, @nishanthp!
There is a formatting issue, thought: https://github.com/redis/mcp-redis/actions/runs/19199746370/job/54979827575
You can fix it by running uv run ruff format on your branch.
There was a problem hiding this comment.
@vchomakov Ran the format command locally. I have pushed the changes.
There was a problem hiding this comment.
test_server_tool_count_and_names and test_server_lists_tools fail because the server returns an unexpected tool lrem, and the number of tools is 45, while 44 are expected in the test.
@nishanthp Please, adjust the tests to fix the pipeline failures.
There was a problem hiding this comment.
@vchomakov I initially ran only the tests I added, my mistake. I’ve now executed all the tests for my branch locally. Please see the screenshot below for reference.
nishanthp
force-pushed
the
addlremfunctionality
branch
from
a606bdd to
6125417
Compare
nishanthp
force-pushed
the
addlremfunctionality
branch
from
1d20bf4 to
e326f04
Compare
3 participants
This PR implements the LREM (List Remove) functionality in list.py, enabling removal of list elements by value with count-based control.
Changes:
lremfunction to support Redis LREM commandcount > 0: Remove elements from head to tailcount < 0: Remove elements from tail to headcount = 0: Remove all matching elementsUsage: