Fix type annotations for models#520
Closed
golyalpha wants to merge 1 commit intoredis:mainfrom
Closed
Conversation
Classmethods `get` type annotations declared their return type as the various base model classes. This broke code hints and linters as a result, because they were incorrectly told Model.get returned `HashModel` (or whichever base model was in use) rather than `Model`.
Collaborator
|
Closing this PR due to staleness (18 months), but the improvement is valid and now tracked in #742. Thank you @golyalpha for identifying this typing issue! The approach of using a TypeVar for proper return type inference is correct. We'll reference this PR when implementing the fix. See #742 for continued discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Classmethods
gettype annotations declared their return type as the various base model classes.This broke code hints and linters as a result, because they were incorrectly told Model.get returned
HashModel(or whichever base model was in use) rather thanModel.