-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typings to the redis.Redis
class
#3252
base: master
Are you sure you want to change the base?
Conversation
In some parameters, I don't know what is the proper type. I'll fix these later. |
Hi @bitterteriyaki, thanks for your desire to contribute! Currently redis-py supports Python 3.8 up to and including 3.11, and support for 3.12 is planned. In general it's best to use language constructs that work in all these versions. For example |
Hi, @gerzse. Thank you for the answer. Since Python 3.7 was dropped, It would be nice to update the documentation.
Alright. I'll be changing this.
According to the |
Instead of |
Hi, @Vulwsztyn. This PR is still a draft and it is not complete. Review once I finish it, please. |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
NOTE: This PR adds breaking changes.
This PR aims to add static typings to the
redis.client.Redis
class. This is still a work in progress and this PR must not be merged yet. Please give me any feedback on that.