Skip to content

Support the customization of the timeout parameter when using a blocking connection pool with a redis cluster #3724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VincentHokie
Copy link

@VincentHokie VincentHokie commented Jul 31, 2025

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

Description of change

The timeout parameter is not one of the allowed redis keys, despite it being used for BlockingConnectionPool uses.

Because we need to let the RedisCluster configure its connection pools, we need to pass in the parameters that eventually make it to the creation of the connection pool.

Whitelisting the timeout key does this, and a test has been added to validate this.

@VincentHokie VincentHokie changed the title Support the customization of the timeout parameter when using a blockig connection pool with a redis cluster Support the customization of the timeout parameter when using a blocking connection pool with a redis cluster Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant