feat : Implement slot-based MGET batching for cluster clients #908
Conversation
Implement slot-based MGET batching for cluster clients Co-authored-by: SoulPancake <[email protected]>
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
|
I optimised the slice mem allocation, is there any other potential improvement I can work on? @rueian |
| i := 0 | ||
| for _, cmd := range slotCmds { | ||
| cmds.s[i] = cmd.Pin() | ||
| i++ | ||
| } |
There was a problem hiding this comment.
Can we put i into the loop?
| i := 0 | ||
| for _, cmd := range slotCmds { | ||
| cmds.s[i] = cmd.Pin() | ||
| i++ | ||
| } |
There was a problem hiding this comment.
Can we put i into the loop?
| if err := resp.NonRedisError(); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
| if err := resp.NonRedisError(); err != nil { | |
| return nil, err | |
| } |
The below resp.ToArray should cover this already.
| if err := resp.NonRedisError(); err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
| if err := resp.NonRedisError(); err != nil { | |
| return nil, err | |
| } |
The below resp.ToArray() should cover this already.
| if len(slotCmds) == 0 { | ||
| return ret, nil | ||
| } |
I wonder if it is possible to avoid using |
@rueian |
|
|
I have some trouble will my personal laptop, I will address these in a week approx, hope that is okay |
2 participants
For #844