Repository navigation
Add shared retry-command composite action - #16
Merged
Merged
Conversation
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RediSearch and RSE repeat setup retry loops, including before checkout, where a local action is unavailable. Add RediSearch's existing
retry-commandas a shared composite action so callers can use one implementation remotely.Preserves the existing inputs and behavior: five attempts with 30-second delays by default, configurable working directory, login Bash with pipefail, and an optional step-scoped GitHub token. The implementation is copied unchanged from RediSearch commit
33d90342bc9c601d904fb58446f8bda4eaba5011. README documents usage, shell failure semantics, and availability through@v1after release. Caller migrations and release tagging are separate changes.Validation: strict YAML parsing with duplicate-key rejection across the repository; Python compileall; git diff --check; seven shell smoke checks covering immediate success, transient failure, exhaustion, working directory, absent/provided token, and pipeline failure. Actionlint is not installed locally; repository CI will run it.
Note
Low Risk
CI plumbing only—new optional composite action and documentation; no changes to auth, runtime product code, or existing workflows until consumers adopt it.
Overview
Adds a shared
retry-commandcomposite action so consuming repos can run setup-style shell steps with bounded retries instead of duplicating loops locally (including steps that run before checkout).The action retries a caller-supplied
commandup to five times with 30-second delays by default, supportsworking_directoryand an optional step-scopedgithub_token(exported asGITHUB_TOKENonly when set), and fails the step if all attempts fail. It uses login Bash withpipefailandevalin anif, so multi-command strings should chain with&&.The README lists the action in Shared CI utilities and adds a Retrying setup commands section with a
@v1usage example, shell failure semantics, and notes that no checkout of this repo is required for the action itself.Reviewed by Cursor Bugbot for commit bfc281b. Bugbot is set up for automated code reviews on this repo. Configure here.