Update template for React 18 and React-Redux v8

[souzaramon]

#52

[souzaramon]

I think that's it

[markerikson]

Hmm. Looks like our Github workflow needs to be updated to set NODE_ENV=test ?

Run npm run lint

> [email protected] lint /home/runner/work/cra-template-redux/cra-template-redux
> eslint './template/src/**/*.js'

/home/runner/work/cra-template-redux/cra-template-redux/template/src/App.js
  0:0  error  Parsing error: [BABEL] /home/runner/work/cra-template-redux/cra-template-redux/template/src/App.js: Using `babel-preset-react-app` requires that you specify `NODE_ENV` or `BABEL_ENV` environment variables. Valid values are "development", "test", and "production". Instead, received: undefined. (While processing: "/home/runner/work/cra-template-redux/cra-template-redux/node_modules/babel-preset-react-app/index.js")

Can I have you tweak that and get the check passing?

[souzaramon]

Hmm. Looks like our Github workflow needs to be updated to set NODE_ENV=test ?

Run npm run lint

> [email protected] lint /home/runner/work/cra-template-redux/cra-template-redux
> eslint './template/src/**/*.js'

/home/runner/work/cra-template-redux/cra-template-redux/template/src/App.js
  0:0  error  Parsing error: [BABEL] /home/runner/work/cra-template-redux/cra-template-redux/template/src/App.js: Using `babel-preset-react-app` requires that you specify `NODE_ENV` or `BABEL_ENV` environment variables. Valid values are "development", "test", and "production". Instead, received: undefined. (While processing: "/home/runner/work/cra-template-redux/cra-template-redux/node_modules/babel-preset-react-app/index.js")

Can I have you tweak that and get the check passing?

I add NODE_ENV=test in the github flow and in dev I had to add NODE_ENV=dev too, that is a issue about this here.

facebook/create-react-app#2377

And thinking about windows env, cross-env should be the simplier solution.

[markerikson]

Looks good!