fix status dot color selectors in build/system24.css #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
aria-labels change by language, so i don't believe that is a viable path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the css in
build/system24.cssselects the status dot elements withhas(rect[fill="..."])and just matches on the colour that it normally would be. This doesn't work when using a reduced saturation in the base discord accessibility settings, as the colour of the dot is slightly different, so every status dot is just transparent and doesn't work.Ex. the normal colour of the green "online" dot is #43A25A. When saturation is at 75%, the colour is now #4F9661, so
.wrapper__44b0c:has(rect[fill='#d83a42'])(code in main) does not notice it anymore.Instead you can select them with the
aria-labelattribute, which is always the same and works just fine.