Ensure the dummy app uses the same template as real apps. #3180
+125
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Refinery does not necessarily expect action_mailer to be available as | ||
| # we may not always require it (currently only the authentication extension). | ||
| # Rails, however, will optimistically place config entries for action_mailer. | ||
| current_mailer_config = mailer_config(env_file) |
There was a problem hiding this comment.
This mailer stuff should be done by refinerycms-inquiries. The core doesn't send mail.
Maybe this whole thing shouldn't even be our concern?
parndt
force-pushed
the
feature/consistent-dummy-app
branch
from
5a6d709
to
2ce8d43
Compare
parndt
force-pushed
the
feature/consistent-dummy-app
branch
from
8665525
to
857fff4
Compare
|
Hi @parndt ! Could you update your PR? |
bricesanchez
force-pushed
the
feature/consistent-dummy-app
branch
from
4e629b3
to
d8a577b
Compare
|
I've tried to fix specs on this PR but i'm not sure if my commits helps. Please, could you check if you can fix specs @parndt ? |
This should fix pages fails on MySQL. I suspect, "skip_migrate" is not the right option name, "skip_migration" is also used to skip the seeds in: https://github.com/refinery/refinerycms/blob/10e63784613682db8f8b094878f60a01413b39f6/core/lib/generators/refinery/cms/cms_generator.rb#L269
parndt
force-pushed
the
feature/consistent-dummy-app
branch
from
c04b169
to
c3cac10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fails
This is work I was doing last July, but it still seems like a good thing to work on. I wasn't happy that the dummy app used a different template than the one we ask people to install with because this way we can implicitly test that template's always correct.
It needs rebasing and validating.