Improve handling of maintenance reservations in Slurm #3573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekouts
changed the title
MAINTENANCE to the available states for nodes that belong in a Slurm reservation with the MAINT flag.
… feat/maint_nodes
ekouts
changed the title
MAINTENANCE to the available states for nodes that belong in a Slurm reservation with the MAINT flag.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3573 +/- ##
===========================================
- Coverage 91.26% 91.22% -0.05%
===========================================
Files 62 62
Lines 13534 13540 +6
===========================================
Hits 12352 12352
- Misses 1182 1188 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ekouts
changed the title
… feat/maint_nodes
ekouts
commented
Oct 22, 2025
Comment on lines
+444
to
+446
| # else: | ||
| # raise JobSchedulerError(f"could not extract the reservation " | ||
| # f"flags for reservation '{reservation}'") |
There was a problem hiding this comment.
I wasn't sure if we want to fail here or silently ignore it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MAINTENANCEto the available states for nodes that belong in a reservation with theMAINTflag, when the user explicitly requests for this reservation.Fixes #3572 .