fix: modified ctrl-v past behavior #105
Merged
+1
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilmer
requested changes
Mar 24, 2025
src/DialogWindow.vala
Outdated
| @@ -496,10 +496,9 @@ namespace Ilia { | |||
|
|
|||
| if (entry.get_selection_bounds(out start, out end)) { | |||
| entry.get_buffer().delete_text(start, end - start); | |||
| entry.get_buffer().insert_text(start, text.data); | |||
| entry.insert_at_cursor(text); | |||
There was a problem hiding this comment.
Given that this is repeated in both branches of the predicate, please move it out to the line below
There was a problem hiding this comment.
should've thought of that, i'll add the changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ctrl-v paste behavior
Before
Ctrl -v added text after cursor, keeping cursor where it was
oldi.mp4
Now
Ctrl -v adds text before the cursor, moving cursor forward
newi.mp4
as discussed in #97