-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fixup nvtools migration message #3911
DOC: Fixup nvtools migration message #3911
Conversation
Merge if passing |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3911 +/- ##
==========================================
- Coverage 76.85% 76.83% -0.02%
==========================================
Files 137 137
Lines 15344 15351 +7
==========================================
+ Hits 11792 11795 +3
- Misses 3552 3556 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
||
name = "NVIDIA Tools Migrator" | ||
|
||
rerender = True | ||
|
||
max_solver_attempts = 3 | ||
|
||
migrator_version = 0 | ||
migrator_version = 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will reissue all PRs the migrator ever made. Did you mean to do that?
We almost never due that because it is a bit spammy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think that is ok. We are the ones creating and receiving the spam
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to know for the future. Luckily only a few PRs had been opened, so there were few duplicates. How do you update an in-progress migrator, then? i.e. have the bot rerun unedited pull requests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well you have two choices.
- Leave the migrator_version as is and the bot will use the updates for new PRs, but leave old ones alone.
- Bump the migrator_version and get new PRs for everything.
There is no feature to go back and edit pull requests already issued.
|
||
More information about cf-nvidia-tools is available in the feedstock's [README](https://github.com/conda-forge/cf-nvidia-tools-feedstock/tree/main/recipe). | ||
|
||
Please ping carterbox for questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a future note let's also link the main issue so it is easier to track all the migration PRs that are made and see when they are closed out
Please ping carterbox for questions. | |
Please ping carterbox for questions. | |
xref: https://github.com/conda-forge/cuda-feedstock/issues/62 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point, since the migrations tracking page doesn't update immediately.
Description:
Tweaking the NVIDIA Tools migrator to fix formatting in the commit message and to add title, commit message, and branch name.
Checklist:
Cross-refs, links to issues, etc: