Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): don't round trip field ids #357

Merged
merged 1 commit into from
Feb 17, 2025
Merged

chore(api): don't round trip field ids #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased
- Fix a typo in get datasets docs
- Don't round trip field ids due to new server side matching logic

# v0.36.2
- Add ai unit charge consent for `parse pst`
Expand Down
4 changes: 0 additions & 4 deletions api/src/resources/comment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,8 +873,6 @@ pub struct NewEntityWithSpan {
pub name: EntityName,
pub formatted_value: String,
pub span: NewEntitySpan,
#[serde(skip_serializing_if = "Option::is_none")]
pub field_id: Option<FieldId>,
}

#[derive(Debug, Clone, PartialEq, Deserialize, Serialize, Eq)]
Expand All @@ -884,8 +882,6 @@ pub struct FieldId(pub String);
pub struct NewEntityWithSpans {
pub name: EntityName,
pub formatted_value: String,
#[serde(skip_serializing_if = "Option::is_none")]
pub field_id: Option<FieldId>,
pub spans: Vec<NewEntitySpan>,
}

Expand Down
Loading