fix: remove hardcoded Android dependency from h5vcc_tizen_tube BUILD.gn for Linux builds - #293
Open
starfish367 wants to merge 1 commit into
Open
fix: remove hardcoded Android dependency from h5vcc_tizen_tube BUILD.gn for Linux builds#293starfish367 wants to merge 1 commit into
starfish367 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When compiling Cobalt for Linux/Evergreen targets (like
evergreen-arm64), the build fails during the GN generation phase. This is because the custom moduleh5vcc_tizen_tubehardcodes a dependency on//starboard/android/shared:starboard_platformin itsBUILD.gn, which triggers the following assertion failure:assert(is_android || is_chromeos || is_robolectric)Solution
Removed the hardcoded Android starboard platform dependency from
third_party/blink/renderer/modules/cobalt/h5vcc_tizen_tube/BUILD.gnto allow successful compilation on non-Android (Linux) targets.