Wait for connect to finish sending all data #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've found an issue that the one last byte generated by I've added channels to wait for go funcs launched in connect() to finish their jobs. |
thayama
force-pushed
the
sync-with-handler
branch
from
c8d60d6
to
c718c3b
Compare
Goroutines created in connect, transfer data from a handler to telnet client. However, as there's no synchronization between the goroutines and the telnet server, there's a case where the server sends a prompt before the goroutines finishsed all transmissions. This fix assure that the telnet server waits until all data are sent to the client, before sending a prompt.
thayama
force-pushed
the
sync-with-handler
branch
from
c718c3b
to
75a5079
Compare
|
My vote for this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goroutines created in connect, transfer data from a handler to telnet
client. However, as there's no synchronization between the goroutine
and the telnet server, there's a case where the server sends a prompt
before the goroutines finished all transmissions.
This fix assure that the telnet server waits until all data are sent to
the client, before sending a prompt.