Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notify): support 'fromName' in SMTP messages #513

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

JosephKav
Copy link
Collaborator

Doesn't look like containrrr/shoutrrr#430 is gonna be merged any time soon, so have moved the param to the shoutrrr url.

fixes #352

@JosephKav JosephKav added the bug Something isn't working label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.56%. Comparing base (28fbb1d) to head (5397fe5).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   98.56%   98.56%   +0.01%     
==========================================
  Files         120      120              
  Lines       10277    10279       +2     
==========================================
+ Hits        10128    10130       +2     
  Misses        121      121              
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JosephKav JosephKav merged commit e47c332 into master Jan 14, 2025
7 checks passed
@JosephKav JosephKav deleted the 352-bug-smtp-e-mail-fromname-xxx-not-working branch January 14, 2025 20:54
@JosephKav JosephKav added the go Pull requests that update Go code label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: SMTP E-Mail "fromname: XXX" not working
1 participant