-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync transform if w/ only explicit plugins #40
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 82 105 +23
=========================================
+ Hits 82 105 +23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All your suggestions are applied. Hope it is fine.
This comment has been minimized.
This comment has been minimized.
Released! Thank you! |
Initial checklist
Description of changes
I added a synchronous transformer if "options.plugins" doesn't contain a string.
I've been using react-markdown which supports only synchronous transformers. The plugins that I used in the plugin list in my project is about 20, the only async transformer was
remark-textr
which caused a problem. I created a custom plugin in my project, but wanted to share with the community.I added a test and also tested in with ReactMarkdown in my project.
I don't believe it's necessary to add this to the README since it doesn't affect users. This does not require any breaking change.