refactor doc route url parsing #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #190 I realized we had a bug with old tags
For example, if you add
.md
to the end of https://reactrouter.com/6.30.1/start/overview, the redirect will not work properlyThe fix is corrected on staging, so https://reactrouterdotcomstaging.fly.dev/6.30.1/start/overview.md works
Additionally, I went ahead and added (ok ok, cursor added) some tests to ensure that we don't break the behavior in the future.
These tests made it easy to refactor the url parsing logic, which is still a bit hairy, but much more tame now.
@JuanJo4 if you have time I'd love a review since you implemented the original feature :)