Bug report: href() and escaped periods don't work together

[ngbrown]

This pull request updates the bug-report-test.ts to show a failure when using href() on paths that contain an escaped period.

I also updated packages\react-router\__tests__\href-test.ts with a failing test.

I'm using the file route conventions (fs-routes). A route that starts out like this: app\routes\text.$id[.txt].ts is turned into a page string of "/text/:id.txt" by react-router typegen.

This means that this is the only type correct way to use href() is:

href("/text/:id.txt", { id: "a123" })

But the output string is incorrect, as it is only: /text/a123, not /text/a123.txt.

A repository with essentially the same project as the test is available here: https://github.com/ngbrown/react-router-href-with-period

Using something like route("text/:id.txt", "routes/text-file.ts") also works for the routing portion, but doesn't change anything for the href() issue.

I'm not sure on the direction of the fix... whether the team want to change just href() or to also change the pages strings.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 42c7017

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[ngbrown]

I was following the bug reporting process to open this PR, but I now have a possible fix. What should I do next?

My fix is at: https://github.com/ngbrown/react-router/tree/href-with-period-fix (view diff)

[timdorr]

Easiest thing would be to close this out and open a new PR.

[ngbrown]

@timdorr Thanks. I opened a new PR at #13797.