-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
chore(rsc): update vite-rsc for automatic server css support #13826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rsc
Are you sure you want to change the base?
chore(rsc): update vite-rsc for automatic server css support #13826
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @Hardanish-Singh I appreciate you trying to be helpful, but approvals and comments like these aren't helpful, they just add noise. I've seen you jump on a number of PRs with what are essentially auto approvals. If I keep seeing it I'm going to have to block you Please refrain from reviewing PRs in the future unless you are actually giving feedback on the code |
@hi-ogawa What about routes with multiple component exports? Will the API support this? Also, have you see the way Parcel handles this? https://github.com/parcel-bundler/parcel/blob/d948759d2fd502bc0c76cf87480f6fb12d2a2ee6/packages/runtimes/rsc/rsc-helpers.jsx#L22-L90 — it's a bit wild, but I like that consumers don't need to think about it. |
Yes, I've seen Parcel's idea and I'm experimenting with something similar too. I actually just landed this one hi-ogawa/vite-plugins#1030, so I'll update the example here. |
Hey, I'm iterating server css support and this is just one attempt to make it easier for certain routing system. I'm sharing it here in case you are interested. Here is an updated API https://github.com/hi-ogawa/vite-plugins/tree/main/packages/rsc#idvite-rsc-css-exportname. Please feel free to take or close it.
Putting it to draft as I'm thinking more automatic approach.