Repo housekeeping updates #13880

brophdawg11 · 2025-06-24T21:10:03Z

Updates to align with our new governance model

changeset-bot · 2025-06-24T21:10:07Z

⚠️ No Changeset found

Latest commit: 54718fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

brophdawg11 · 2025-06-24T21:10:25Z

.github/ISSUE_TEMPLATE/bug_report.yml

+        Please note that **all** bugs must have a **minimal** reproduction, meaning
+        that it is not just pointing to a deployed site or a branch in your existing
+        application.  Please refer to the [Bug/Issue Process Guidelines](https://github.com/remix-run/react-router/blob/main/GOVERNANCE.md#bugissue-process)
+        for more information.


Slimmed this down a bit and linked off to the more-detailed version

brophdawg11 · 2025-06-24T21:15:15Z

.github/ISSUE_TEMPLATE/bug_report.yml

-        3. Follow the instructions and submit a pull request with a failing bug report test!
-
-        ## Option 2: Continue filling out this form
+        3. Follow the instructions to create a failing bug report test
+        4. Link to your forked branch with the failing test in this issue


I changed this to result in an issue being filed instead of a PR. The issue can point to the fork with the failing e2e test, and then we as maintainers can easily check out the fork and run the failing test and work on a fix. But having a PR with a bug report test always felt a bit odd to me:

The PR isn't actually fixing anything or adding functionality

The Issue isn't actually tracked anywhere as a bug

Makes sense to me! Thanks for reconsidering what had been written for a while at this point

.github/ISSUE_TEMPLATE/bug_report.yml

brophdawg11 · 2025-06-24T21:16:22Z

.github/ISSUE_TEMPLATE/bug_report.yml

-  - type: dropdown
-    id: mode
-    attributes:
-      label: I'm using React Router as a...
-      description: See https://reactrouter.com/home for explanation
-      options:
-        - library
-        - framework
-    validations:
-      required: true


The vast majority of users never seemed to change this anyway so I got rid of it? With a reproduction it'll be easy enough for us to see which mode they're in I think.

brophdawg11 · 2025-06-24T21:16:36Z

.github/workflows/close-no-repro-issues.yml

+        run: pnpm install --frozen-lockfile
+
+      - name: 🚪 Close Issues
+        run: node --experimental-strip-types ./scripts/close-without-repro.ts --dryRun


Github action we can trigger manually to run the script

brophdawg11 · 2025-06-24T21:16:42Z

GOVERNANCE.md

@@ -139,5 +139,3 @@ To get a feature accepted and implemented in React Router, it will go through th

 - A proposal enters **Stage 5 — Stable** once it receives **Stage 4 — Stabilization** PR approvals from at least 50% of the SC members and is merged to `dev`
 - This will include the stable feature in `nightly` releases and the next normal SemVer release
-
-[mermaid]: https://mermaid.live/edit#pako:eNqVkm9r2zAQxr_KcTDYwAn-E8eOGYXGScdeFEYzGLQuQ4nPjsCWjCx3beN89yn2rJKX06tDd8_vnpPuhAeZEyZYVPLP4ciUhp-bTIA5t0_fc2LPMJvd9L8U1wQ_lGxky6oe1k8Z7jQrCdyve3Xzecp8yfB5VK8H3XQPrGmUfDFBoWQNPuxSuKd6T6rtIbUwD2aQStHynBTTXAqLS0fcA_C6qagmobkogbXQiVazfUW_e9hYjm84t1VzZFa_mfTXRpiGilirIXQ_gSyubG0tLjC4NekP2naiKarly8WJtQGNooK_9nBn5QsjN9GeV_z9eqq7_3f1zWLDf9iKDA8drEnVjOfmL08Xeob6aB4qw8SEORWsq3SGmTib0q7JmaZtzrVUmBSsaslB1mm5exMHTLTqaCracFYqVtuqhglMTviKySqYh4toFUfxIo6DyPUdfMPEW0ZzNwjNvb9wYz8Ko7OD71IagjuPo1UQL1dLb7F0PS8IB9zjkBx70mDpflzJYTMdVLIrj7Z_qS4jjtWKhFmUVHZCYxKe_wLxVeMU


brophdawg11 · 2025-06-24T21:17:05Z

scripts/close-without-repro-comment.md

@@ -0,0 +1,9 @@
+To align with our new [Open Governance](https://remix.run/blog/rr-governance) model, we are now requiring that all issues have a [minimal reproduction](https://github.com/remix-run/react-router/blob/main/GOVERNANCE.md#bugissue-process). To that end, we're doing some housekeeping in the repo to clean up existing issues that do not have a reproduction. This should get us down to a more manageable number of issues and allow us to be more responsive to existing and newly filed issues.


This is the comment that our github bot will post on issued when it closes them because they're missing a reproduction

brophdawg11 · 2025-06-24T21:17:51Z

scripts/close-without-repro.ts

+  let noReproIssues = issues.filter(({ body }) => {
+    return (
+      !/https?:\/\/stackblitz\.com\//.test(body) &&
+      !/https?:\/\/codesandbox\.io\//.test(body) &&
+      // Look for github links excluding user-uploaded screenshots
+      !/https?:\/\/github\.com\/(?!user-attachments)/.test(body)
+    );
+  });


Decently reliable check for "having a reproduction" as those issues which contain a stackblitz/codesandbox/github repo link in the issue body.

brophdawg11 · 2025-06-24T21:18:11Z

scripts/close-without-repro.ts

+run();
+
+async function run() {
+  let issuesCmd = `gh issue list --search "is:issue state:open label:bug" --limit 250 --json number,body`;


Only look at issues with the bug label

brophdawg11 · 2025-06-24T21:18:37Z

scripts/close-without-repro.ts

+    let commentCmd = `gh issue comment ${issue.number} -F ./scripts/close-without-repro-comment.md`;
+    let commentResult = runCmdIfTokenExists(commentCmd);
+    console.log(`Commented on issue #${issue.number}: ${commentResult}`);
+    await sleep(250);


Comment on the issue with the contents of our markdown file

brophdawg11 · 2025-06-24T21:18:46Z

scripts/close-without-repro.ts

+    let closeCmd = `gh issue close ${issue.number} -r "not planned"`;
+    runCmdIfTokenExists(closeCmd);


Close the issue as not planned

markdalgleish · 2025-06-24T23:34:12Z

scripts/close-without-repro-comment.md

@@ -0,0 +1,9 @@
+To align with our new [Open Governance](https://remix.run/blog/rr-governance) model, we are now requiring that all issues have a [minimal reproduction](https://github.com/remix-run/react-router/blob/main/GOVERNANCE.md#bugissue-process). To that end, we're doing some housekeeping in the repo to clean up existing issues that do not have a reproduction. This should get us down to a more manageable number of issues and allow us to be more responsive to existing and newly filed issues.
+
+We're using a Github actions script to identify issues without a reproduction by looking for a [StackBlitz](https://stackblitz.com/), [CodeSandbox](https://codesandbox.io/), or [Github](https://github.com) link in the issue body. This won't be perfect, so if this issue has a reproduction on another platform, please comment back on here and we can re-open the issue. Similarly, if there's a reproduction buried in a comment, please move the link into the description and comment back. Please tag `@brophdawg11` or `@brookslybrand` in your comment so we get a notification as well 🙂.


I really like how you spell out the logic here and admit that it might not be perfect.

beep boop bot make mistake sometimes 🤖

Add script to close issues without a reproduction

66448f5

remix-cla-bot bot added the CLA Signed label Jun 24, 2025

brophdawg11 commented Jun 24, 2025

View reviewed changes

.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved

Update .github/ISSUE_TEMPLATE/bug_report.yml

e8d752e

brophdawg11 commented Jun 24, 2025

View reviewed changes

markdalgleish reviewed Jun 24, 2025

View reviewed changes

brophdawg11 added 3 commits June 25, 2025 14:40

Rename and change to a limit of 100

281635c

Update

ecaf584

Add note on runnable reproductions

54718fa

brophdawg11 merged commit de0bf83 into main Jun 25, 2025
5 checks passed

brophdawg11 deleted the brophdawg11/sc-script branch June 25, 2025 18:54

MichaelDeBoey mentioned this pull request Jun 25, 2025

chore(close-no-repro-issues): fix grammar #13887

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Repo housekeeping updates #13880

Repo housekeeping updates #13880

brophdawg11 commented Jun 24, 2025

Uh oh!

changeset-bot bot commented Jun 24, 2025 •

edited

Loading

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

brookslybrand Jun 25, 2025

Uh oh!

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

brophdawg11 Jun 24, 2025

Uh oh!

markdalgleish Jun 24, 2025

Uh oh!

brophdawg11 Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -0,0 +1,9 @@
		To align with our new [Open Governance](https://remix.run/blog/rr-governance) model, we are now requiring that all issues have a [minimal reproduction](https://github.com/remix-run/react-router/blob/main/GOVERNANCE.md#bugissue-process). To that end, we're doing some housekeeping in the repo to clean up existing issues that do not have a reproduction. This should get us down to a more manageable number of issues and allow us to be more responsive to existing and newly filed issues.

		let closeCmd = `gh issue close ${issue.number} -r "not planned"`;
		runCmdIfTokenExists(closeCmd);

		@@ -0,0 +1,9 @@
		To align with our new [Open Governance](https://remix.run/blog/rr-governance) model, we are now requiring that all issues have a [minimal reproduction](https://github.com/remix-run/react-router/blob/main/GOVERNANCE.md#bugissue-process). To that end, we're doing some housekeeping in the repo to clean up existing issues that do not have a reproduction. This should get us down to a more manageable number of issues and allow us to be more responsive to existing and newly filed issues.

		We're using a Github actions script to identify issues without a reproduction by looking for a [StackBlitz](https://stackblitz.com/), [CodeSandbox](https://codesandbox.io/), or [Github](https://github.com) link in the issue body. This won't be perfect, so if this issue has a reproduction on another platform, please comment back on here and we can re-open the issue. Similarly, if there's a reproduction buried in a comment, please move the link into the description and comment back. Please tag `@brophdawg11` or `@brookslybrand` in your comment so we get a notification as well 🙂.

Uh oh!

Repo housekeeping updates #13880

Repo housekeeping updates #13880

Conversation

brophdawg11 commented Jun 24, 2025

Uh oh!

changeset-bot bot commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Jun 24, 2025 •

edited

Loading