-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
fix(vite): loadEnv before reading routes #14446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hi @RFCreate, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Could you remove the upgrades to Vite in the package.json files? You only need to upgrade with pnpm, because that version selector will include 6.3.0. |
I would rather not touch versions but pnpm keeps resolving Vite to version |
You can see that with Vite version ![]() @timdorr is there a reason for not moving Vite to |
No, I was just trying to cut down on noise in the PR so the change is more visible. |
The only thing I could think of is to reorder the commits so that the last two are the important ones. |
This PR moves the loadDotEnv function prior to configuring the routes.
Why is this important?
I have another project where routes are dynamically generated based on the value of a
VITE_*
variable, but when runningreact-router dev
, I always get undefined unless I restart manually.This PR removes the need for restarting manually every time.