feat(rsc): add support for throwing redirect Response's at RSC render time #14596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2df3cfb The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
reviewed
Nov 25, 2025
| "react-router": minor | ||
| --- | ||
|
|
||
| add support for throwing redirect Response's at RSC render time |
Contributor
There was a problem hiding this comment.
Can be patch since RSC is still unstable right?
brophdawg11
reviewed
Nov 25, 2025
| !errorRedirectHandledMap.get(error) | ||
| ) { | ||
| // TODO: Handle external redirects? | ||
| setTimeout(() => { |
Contributor
There was a problem hiding this comment.
Can we useNavigate and an effect?
brophdawg11
reviewed
Nov 25, 2025
| window.__reactRouterDataRouter && | ||
| !errorRedirectHandledMap.get(error) | ||
| ) { | ||
| // TODO: Handle external redirects? |
Contributor
There was a problem hiding this comment.
Need to take logic from Link or startRedirectNavigation and turn it into a utility
brophdawg11
reviewed
Nov 25, 2025
| * enables the unstable_useTransitions flag, as well as the ability to handle | ||
| * thrown redirect responses during the render phase. | ||
| */ | ||
| unstable_rsc?: boolean; |
Contributor
There was a problem hiding this comment.
Should be able to check for RSCRouterContext from the usage point and avoid prop drilling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.