Fix backend topic correctness and /topic CORS contracts#134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the approved Phase 02 checklist for backend correctness and
/topicCORS contract alignment.It addresses four scoped intents:
topicDELETEdescendant deletion behavior.topicListGETauth validation behavior./topicCORS declarations with implemented route behavior.Changes
src/lib/MongodbService.tstopicDELETEtopic lookup to resolve a document (findOne) rather than relying on cursor object truthiness.replies[].iddescendants.topicListGETauth lookup to resolve a user document before policy checks.src/lib/backend-utilities.tsgetAllowedOriginsnow trims and filters configured origin entries.isAllowedReferernow matches against both trimmed configured patterns and normalized equivalents to keep advanced glob behavior while enforcing a consistent contract.src/functions/topic.tsAccess-Control-Allow-MethodstoGET,POST,PUT,DELETE,OPTIONS.Access-Control-Allow-HeaderstoCookie,Authorization.example.envALLOW_ORIGINguidance to document referer-pattern normalization and examples consistent with runtime behavior.src/tests/backend/utilities.test.tsdocs/plans/phase-02-backend-correctness-and-cors.mdValidation
yarn jest --config jest.backend.config.ts src/tests/backend/utilities.test.ts src/tests/backend/MongodbService.test.tsyarn test:backendResult: backend suites pass (9/9), tests pass (180/180).
Scope Notes