Pull request creator tests #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coorasse
force-pushed
the
pull_request_creator_tests
branch
from
228b369
to
d1de64f
Compare
coorasse
commented
Oct 30, 2024
Comment on lines
+35
to
+39
| run: bundle exec rails test | ||
|
|
||
| - name: Run system tests | ||
| run: bundle exec rails test:system |
There was a problem hiding this comment.
I expected the tests to fail and they were green
coorasse
force-pushed
the
pull_request_creator_tests
branch
from
9735c50
to
797e7bf
Compare
coorasse
force-pushed
the
pull_request_creator_tests
branch
from
797e7bf
to
d0136b2
Compare
coorasse
commented
Oct 30, 2024
lib/moirai/pull_request_creator.rb
Outdated
| end | ||
|
|
||
| def create_pull_request(translations_array) | ||
| repo = @client.repo(@github_repo_name) | ||
| default_branch = repo.default_branch | ||
| @branch_name = "moirai-translations-#{Time.current.strftime("%F-%H-%M-%S")}" |
There was a problem hiding this comment.
branch name must be different each time, otherwise there might be conflicts, for example when we have different CI, running in parallel. Is also correct that a new branch is created each time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.