feat: add experimental_preferUniversalLinks property to switch to Universal Links by default for mobile linking
#4294
+322
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4aa3266 The changes in this PR will be included in the next version bump. This PR includes changesets to release 21 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
11 Skipped Deployments
|
tomiir
reviewed
Apr 29, 2025
arein
reviewed
Apr 30, 2025
There was a problem hiding this comment.
Universal Link shouldn't be the "default" most likely. Instead only the fallback. Universal Links only work proper if triggered immediately after user interaction. When using Wagmi this is unpredictable as often there are network calls before triggering the Universal Link. That's why a few years back we defaulted to Deep Links.
enesozturk
changed the title
enableUniversalLinks property to switch to Universal Links by default for mobile linking
|
enesozturk
force-pushed
the
enes/apkt-2684-universal-link-fallback-when-deeplink-fails-2
branch
from
661105f to
e6df959
Compare
svenvoskamp
reviewed
May 7, 2025
enesozturk
changed the title
enableUniversalLinks property to switch to Universal Links by default for mobile linkingexperimental_preferUniversalLinks property to switch to Universal Links by default for mobile linking
svenvoskamp
approved these changes
May 13, 2025
enesozturk
deleted the
enes/apkt-2684-universal-link-fallback-when-deeplink-fails-2
branch
Dargon789
pushed a commit
to Dargon789/appkit
that referenced
this pull request
May 18, 2025
…niversal Links by default for mobile linking (reown-com#4294)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces
enableUniversalLinksproperty to let users default to Universal Link as a first approach to trigger mobile wallet links.experimental_preferUniversalLinksproperty where useslink_modeproperty of the wallets if enabled and if that value exist.Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
In App Browser when the deep link is allow listed:
regular-deeplink-allowed.MP4
In App Browser when the deep link is not allow listed and Universal Link is not enabled:
binance-with-ul.MP4
In App Browser when the deep link is not allow listed and Universal Link is enabled:
zerion-ul.MP4
Default OS browser, using "Open" function to re-trigger the deeplink (or UL if enabled):
os-browser-open-button.MP4
Checklist