Skip to content

fix(apns): handling of the certificate expiration error #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geekbrother merged 2 commits into from
May 29, 2025
Merged

fix(apns): handling of the certificate expiration error #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ecfe2f
fix(Apns): handling of the certificate expiration
geekbrother May 20, 2025
50bf07e
fix: fixing clippy
geekbrother May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/providers/apns.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ impl PushProvider for ApnsProvider {
);
Err(Error::ApnsCertificateUnknownCA)
}
dbg if dbg.contains("received fatal alert: CertificateExpired") => {
info!("APNs certificate expired: debug:{dbg}, display: {client_error}");
Err(Error::ApnsCertificateExpired)
}
_ => Err(Error::Apns(e)),
}
}
Expand Down
6 changes: 1 addition & 5 deletions src/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,7 @@ pub fn new_state(
#[cfg(feature = "multitenant")]
let jwt_secret = config.jwt_secret.clone();

let public_ip = match networking::find_public_ip_addr() {
Ok(ip) => Some(ip),
// Note: Should we pass this error back up?
Err(_e) => None,
};
let public_ip = networking::find_public_ip_addr().ok();
Copy link
Copy Markdown
Contributor Author

@geekbrother geekbrother May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing clippy error.

Copy link
Copy Markdown

@zthrigger zthrigger Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

Comment thread
geekbrother marked this conversation as resolved.

Ok(AppState {
config: config.clone(),
Expand Down
Loading