Skip to content

fix: remove create_topic RPC and watch API#101

Merged
xDarksome merged 8 commits into
mainfrom
copilot/remove-create-topic-rpc
May 15, 2026
Merged

fix: remove create_topic RPC and watch API#101
xDarksome merged 8 commits into
mainfrom
copilot/remove-create-topic-rpc

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 20, 2026

Removes the wc_createTopic RPC method and the irn_watchRegister/irn_watchUnregister watch API, including all associated types, client methods, and the webhook example.

relay_rpc

  • Removed CreateTopic, CreateTopicError and all watch types (WatchRegister, WatchUnregister, WatchError, WatchRegisterResponse)
  • Removed Params::CreateTopic, Params::WatchRegister, Params::WatchUnregister enum variants
  • Deleted rpc/watch.rs module entirely

relay_client

  • Removed http::Client::create_topic, watch_register, watch_register_behalf, watch_unregister
  • Removed WatchRegisterRequest, WatchUnregisterRequest, HttpClientError::Jwt
  • Removed websocket::Client::create_topic
  • Dropped unused origin field from http::Client (was only populated to support watch JWT claims)

root

  • Deleted examples/webhook.rs and removed its [[example]] entry and warp dev-dependency

How Has This Been Tested?

Existing unit tests pass (cargo test -p relay_rpc -p relay_client).

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • binaries.soliditylang.org
    • Triggering command: /home/REDACTED/work/reown-rust/reown-rust/target/debug/build/relay_rpc-c16ca19e5d190591/out/../../../../.foundry/bin/forge /home/REDACTED/work/reown-rust/reown-rust/target/debug/build/relay_rpc-c16ca19e5d190591/out/../../../../.foundry/bin/forge build --contracts=relay_rpc/contracts --cache-path /home/REDACTED/work/reown-rust/reown-rust/target/debug/build/relay_rpc-c16ca19e5d190591/out/../../../../.foundry/forge/cache --out /home/REDACTED/work/reown-rust/reown-rust/target/debug/build/relay_rpc-c16ca19e5d190591/out/../../../../.foundry/forge/out 8bff5/build_script_build-7f48b6ffb558bff5.25hh9b8cgpung0klf2eux2wr6.0yetwzb.rcgucfg(feature, values()) 8bff5/build_script_build-7f48b6ffb558bff5.26nxbzwnhj0jun2idwhmpp51o.0yetwzb.rcgu-C 8bff5/build_script_build-7f48b6ffb558bff5.26phwlp9tw2xm5fx3bo2yxwjg.0yetwzb.rcgu.o 8bff5/build_script_build-7f48b6ffb558bff5.2g06m1oemylgspsn6o6b9qqjd.0yetwzb.rcgu.o 8bff5/build_script_build-7f48b6ffb558bff5.2gwcqiuke1fkyot6v86n0v7s6.0yetwzb.rcgu.o 8bff�� 8bff5/build_script_build-7f48b6ffb558bff5.2nf96x6renfbnl12hu9nfhx9h.0yetwzb.rcgu.o 8bff5/build_script_build-7f48b6ffb558bff5.2xjdbkpd3hnfhi2pztm3bp85k.0yetwzb.rcgu.o de/node/bin/as c 826f7a68079e6751-E pointer os.358bef6722a45-Wall (dns block)
    • Triggering command: /home/REDACTED/work/reown-rust/.codeql-scratch/dbs/rust/working/target/debug/build/relay_rpc-37c5f631bf17a953/out/../../../../.foundry/bin/forge /home/REDACTED/work/reown-rust/.codeql-scratch/dbs/rust/working/target/debug/build/relay_rpc-37c5f631bf17a953/out/../../../../.foundry/bin/forge build --contracts=relay_rpc/contracts --cache-path /home/REDACTED/work/reown-rust/.codeql-scratch/dbs/rust/working/target/debug/build/relay_rpc-37c5f631bf17a953/out/../../../../.foundry/forge/cache --out /home/REDACTED/work/reown-rust/.codeql-scratch/dbs/rust/working/target/debug/build/relay_rpc-37c5f631bf17a953/out/../../../../.foundry/forge/out /home/REDACTED/work/reown-rust/.codeql-scratch/dbs/rust/working/target/debug/deps/libsyn-e1c96a7797b61fd0.rlib futures_macro-3927f55cf91621ae.futures_macro.450e5fcfc49ae9a8-cgu.0.rcgu.o futures_macro-3927f55cf91621ae.futures_macro.450e5fcfc49ae9a8-cgu.1.rcgu.o futures_macro-3927f55cf91621ae.futures_macro.450e5fcfc49ae9a8-cgu.2.rcgu.o futures_macro-3927f55cf91621ae.futures_macro.450e5fcfc49ae9a8-cgu.3.rcgu.o futures_macro-3927f55cf91621ae.futures_macro.450e5fcfc49ae9a8-cgu.4.rcgu.o futures_macro-3927f55cf91621ae.futures_macro.450e5fcfc49ae9a8-cgu.5.rcgu.o /home/REDACTED/wor--json=diagnostic-rendered-ansi,artifacts,future-incompat futures_macro-3927f55cf91621ae.5ch9vxvn74xfbsh7re80ie1oa.rcgu.o 7543991641147detcc deql-scratch/dbs-Wl,--version-script=/tmp/rustcpflWNT/list libsyn-e1c96a7797b61fd0.rlib libquote-819bddae12a512e2.rlib (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: xDarksome <22872975+xDarksome@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove create_topic RPC and watch API Remove create_topic RPC and watch API Feb 20, 2026
Copilot AI requested a review from xDarksome February 20, 2026 11:14
@xDarksome xDarksome changed the title Remove create_topic RPC and watch API fix: remove create_topic RPC and watch API Apr 16, 2026
@xDarksome xDarksome marked this pull request as ready for review April 16, 2026 16:21
@xDarksome xDarksome requested a review from mario-reown April 16, 2026 16:22
@mario-reown
Copy link
Copy Markdown

@xDarksome do you think it would make sense to add metrics for the old endpoints just to be sure that nobody is using them or we can just merge as is?

@xDarksome
Copy link
Copy Markdown
Contributor

@xDarksome do you think it would make sense to add metrics for the old endpoints just to be sure that nobody is using them or we can just merge as is?

We already have the metrics for the watch API, only notify is using it.

batch_fetch and fetch are not being removed, just deprecated and made no-op.

Copilot AI review requested due to automatic review settings April 24, 2026 14:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@xDarksome xDarksome merged commit bdd4346 into main May 15, 2026
9 checks passed
@xDarksome xDarksome deleted the copilot/remove-create-topic-rpc branch May 15, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants