Skip to content

Make whichLanguage -l still respect availability #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

blast-hardcheese
Copy link
Collaborator

Why

In a pnpm project, when asking for -l python, I get python3-uv even though uv is not configured for that project:

$ upm which-language -l python
python3-uv
$ upm which-language -a  # Note, does not include python3-uv
nodejs-pnpm

We were not checking whether the backend is available before printing

What changed

Make which-languages -l ... respect the semantics of which-languages -a

Test plan

Describe what you did to test this change to a level of detail that allows your reviewer to test it

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner April 14, 2025 23:27
@blast-hardcheese blast-hardcheese requested review from ryantm and removed request for a team April 14, 2025 23:27
@blast-hardcheese blast-hardcheese enabled auto-merge (squash) April 14, 2025 23:28
@blast-hardcheese blast-hardcheese merged commit 2f3a662 into main Apr 15, 2025
5 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/availability branch April 15, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants