fix: split iPhone/iPad orientations for App Store validation; set version 1.0(1) - #1
Open
seongilp wants to merge 3 commits into
Open
fix: split iPhone/iPad orientations for App Store validation; set version 1.0(1)#1seongilp wants to merge 3 commits into
seongilp wants to merge 3 commits into
Conversation
A rapid double-tap on a video could spawn two playerItem loads; both passed the guards and each set player + a periodic time observer. The second overwrote the first's references, orphaning the first player's observer (never removeTimeObserver'd) — a leak, plus possible double audio. Re-check player == nil after the await so the late load bails.
…sion 1.0(1) - iPad requires all four orientations (incl. PortraitUpsideDown) or App Store validation rejects a universal app (error 90474). Split the single UISupportedInterfaceOrientations key into _iPhone (3) and _iPad (4). - Add MARKETING_VERSION 1.0 / CURRENT_PROJECT_VERSION 1 (were defaulting).
…ance prompt App uses only standard HTTPS/system encryption, which is exempt. Declaring this in Info.plist removes the 'Missing Compliance' prompt on every TestFlight/App Store upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two
project.ymlissues uncovered while shipping the first TestFlight build (1.0 (1), now VALID on App Store Connect).TARGETED_DEVICE_FAMILY "1,2"), App Store validation rejected the upload (error 90474) because iPad multitasking requires all four orientations. Split the singleUISupportedInterfaceOrientationskey into:_iPhone: Portrait, LandscapeLeft, LandscapeRight (no upside-down — standard for phones)_iPad: all four, incl.PortraitUpsideDownMARKETING_VERSION 1.0/CURRENT_PROJECT_VERSION 1(were silently defaulting).Test plan
xcodegen generatesucceedsxcodebuild archivesucceedsxcodebuild -exportArchive(app-store-connect) uploads without the 90474 rejection1.0 (1)reaches VALID state on App Store Connect / TestFlightNotes
Deploy also required a non-repo workaround: run
-exportArchivewith a system-onlyPATHso Apple'sopenrsyncis used on both ends (Homebrewrsync 3.4.4in PATH otherwise causes a genericCopy failedat packaging). Captured in project memory.