Skip to content

Hiding the top nav on mobile devices feels extremely janky #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kantuni opened this issue Jul 28, 2024 · 3 comments · Fixed by #902
Closed

Hiding the top nav on mobile devices feels extremely janky #899

kantuni opened this issue Jul 28, 2024 · 3 comments · Fixed by #902

Comments

@kantuni
Copy link
Contributor

kantuni commented Jul 28, 2024

The functionality introduced in Hide top nav on reading docs on mobile feels extremely janky. Please fix the flicker when hiding or showing the top nav.

@cometkim
Copy link
Member

cometkim commented Aug 2, 2024

Can you record it?

@cometkim
Copy link
Member

cometkim commented Aug 3, 2024

please let me know if the problem persists.
However the feature only uses the transform of an isolated context. I guess it's more likely a different issue.

@kantuni
Copy link
Contributor Author

kantuni commented Aug 6, 2024

It looks like #902 fixed it. I can still see slight flickering, but very rarely. It might be a good idea to add some leeway before showing the header.

In any case, thank you so much for tackling this so fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants