Skip to content

update scrollDir state less frequently #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2024
Merged

update scrollDir state less frequently #902

merged 1 commit into from
Aug 3, 2024

Conversation

cometkim
Copy link
Member

@cometkim cometkim commented Aug 2, 2024

Trying to resolve #899

  • Now scrollDir state to be synced less frequently
  • The state updating does not rely on the React transition anymore
  • Also fixed the hiding behavior on Safari. scrollY on the top position can be a minus value on Safari

@vercel Vercel
Copy link

vercel bot commented Aug 2, 2024

@cometkim is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

@fhammerschmidt fhammerschmidt merged commit c443793 into rescript-lang:master Aug 3, 2024
1 of 2 checks passed
@cometkim cometkim deleted the fix-nav branch August 3, 2024 08:32
@kantuni kantuni mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hiding the top nav on mobile devices feels extremely janky
2 participants
@cometkim @fhammerschmidt