Add @uncurry decorator syntax lookup#179
Merged
ryyppy merged 5 commits intorescript-lang:masterfrom Jan 15, 2021
kevanstannard:uncurry-decorator-syntax
Merged
Add @uncurry decorator syntax lookup#179ryyppy merged 5 commits intorescript-lang:masterfrom kevanstannard:uncurry-decorator-syntax
ryyppy merged 5 commits intorescript-lang:masterfrom
kevanstannard:uncurry-decorator-syntax
Conversation
ryyppy
reviewed
Jan 10, 2021
ryyppy
requested changes
Jan 13, 2021
Member
ryyppy
left a comment
ryyppy
left a comment
There was a problem hiding this comment.
Some small rephrasing required.
Small note: A paragraph should always be in one line, so it's easier to diff on them (use line-wrapping for editing)
ryyppy
reviewed
Jan 15, 2021
| @@ -0,0 +1,36 @@ | |||
| --- | |||
| id: "uncurry-decorator" | |||
| keywords: ["uncurry", "decorator"] | |||
Member
There was a problem hiding this comment.
before i forget, one of the keywords should probably also be @bs.uncurry, due to the fact that we will have a lot of users on old versions of ReScript / older blog posts that still use the @bs. prefix convention.
Not a blocker, just wanted to mention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for the
@uncurrydecorator syntax page for #162I've experimented with this one a little, but I haven't yet found it to make any difference. I.e. using the decorator or omitting the decorator had no obvious effect on how the callback is called, or the resulting generated JS code.
I'm guessing the code I've tried so far has not been complex enough to trigger the benefits this decorator brings? Just thought I would mention it.
As usual, happy to receive any feedback on this PR.