Integrate genType as 'TypeScript Interop' chapter into main docs#755
Merged
fhammerschmidt merged 11 commits intorescript-lang:masterfrom Jan 12, 2024
Merged
Conversation
e17925f to
2fefef8
Compare
cometkim
reviewed
Dec 5, 2023
cometkim
reviewed
Dec 5, 2023
Member
|
I built the homepage and took a quick look at the outline. This is the feedback so far.
Can you update any changes you are working on? I might submit another PR to your branch. |
3950ce4 to
9889c7d
Compare
Member
Author
|
This new version of the PR is totally simplified since lot's of runtime conversion features were removed, FCMs do not work (according to @cometkim) and more things got deprecated. That way we would promote genType to the seamless experience it should be. But for now I think this is the fastest path going forward. Let's merge this soon. |
…iation/uncurried-docs
Co-authored-by: Florian Hammerschmidt <fh@cca.io>
ffe5a1b to
aae07eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things I'd change now that we have the chance to make structural changes to the genType docs: