Skip to content

Conversation

@nojaf
Copy link
Member

@nojaf nojaf commented May 23, 2024

@vercel
Copy link

vercel bot commented May 23, 2024

@nojaf is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

@nojaf
Copy link
Member Author

nojaf commented May 23, 2024

npm ERR! npm ci can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

My change feels unrelated to this. Should I update the lock file?

@fhammerschmidt
Copy link
Member

Yes please. And thank you already for this nice contribution.

@nojaf
Copy link
Member Author

nojaf commented May 23, 2024

Alright, done!

@fhammerschmidt
Copy link
Member

Sorry, I just merged another PR from @tsnobip where we also updated the lockfile. You can remove the lockfile changes again

@nojaf
Copy link
Member Author

nojaf commented May 24, 2024

@fhammerschmidt good to go? Or would you like to see some changes to the content?

@fhammerschmidt
Copy link
Member

Good to go! Thanks again.

@fhammerschmidt fhammerschmidt merged commit c37b1b5 into rescript-lang:master May 24, 2024
@nojaf nojaf deleted the scope-example branch May 24, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants