Require whitespace before as in to/downto labels
#1085
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RE_TO_DOWNTO_AS_LABELS` rule previously used `\s*` between `(to|downto)` and `(as)`, allowing zero spaces and accidentally matching identifiers like "toast". Change the pattern to `\s+` so that an actual space is required, preventing spurious `as` highlighting inside identifiers.
… apply to labelled arguments
|
I've also prefixed these patterns with |
|
Great stuff! @mediremi could you add a changelog? |
|
@zth changelog entry added |
|
@mediremi awesome. Thank you for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grammar rule
RE_TO_DOWNTO_AS_LABELScontains two patterns for ensuring that labelled arguments with namestoanddowntoare highlighted as variables and not keywords.The second pattern,
(to|downto)\s*(as), is supposed to match cases like(~to as to2) => ..., but was also matching e.g.~toast.I've fixed this by changing
\s*to\s+.