[WIP] Editor mode #7369
Draft
[WIP] Editor mode #7369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zth, I tried to play with this locally, but I can't get the library to build:
Is this working for you? |
Seeing the same locally. I had this previously, but can't remember what it was. Will try and have a look soon. |
…errors to produce more type information
zth
force-pushed
the
analysis-simplification
branch
from
8204d40 to
cdbed51
Compare
nojaf
reviewed
Apr 27, 2025
| import { spawn, spawnSync } from "node:child_process"; | ||
|
|
||
| // Get the current ReScript version | ||
| const rescriptVersion = spawnSync("./node_modules/.bin/bsc", ["-v"]) |
There was a problem hiding this comment.
Nitpick, but we probably have a better way to detect the bsc.exe.
Using cli/bin_path.js. @cometkim probably knows what to use.
nojaf
reviewed
Apr 27, 2025
| @@ -0,0 +1,7 @@ | |||
| exports[`RecordFieldCompletions.res - Record field completion in nested record 1`] = ` | |||
There was a problem hiding this comment.
I know you didn't focus on this, but this really is an unreadable snapshot file.
nojaf
reviewed
Apr 27, 2025
| "dir": "support_files" | ||
| }, | ||
| { | ||
| "dir": "test_files/.build" |
There was a problem hiding this comment.
What exactly is the extra content from this .build folder?
Merged
* Use Vitest to have individual snapshot files * Show completable item in code fence * Update existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.