Skip to content

[WIP] Improve subtype error messages #7404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

[WIP] Improve subtype error messages #7404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8668aec
structure for improving subtype errors
zth Apr 24, 2025
ef59ae4
variant configuration errors
zth Apr 24, 2025
a691b52
different constructor counts
zth Apr 24, 2025
99b253e
format
zth Apr 24, 2025
b89753b
update test output
zth Apr 24, 2025
9c40653
different type kinds
zth Apr 24, 2025
318efa9
missing fn
zth Apr 24, 2025
48e1ff2
record fields mismatch
zth Apr 24, 2025
95aca76
more hints about what types we are looking at
zth Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions compiler/ml/ast_untagged_variants.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,17 @@ type block_type =
| ObjectType
| UnknownType

let block_type_to_string = function
| IntType -> "int"
| StringType -> "string"
| FloatType -> "float"
| BigintType -> "bigint"
| BooleanType -> "bool"
| InstanceType i -> Instance.to_string i
| FunctionType -> "function"
| ObjectType -> "object"
| UnknownType -> "unknown"

(*
Type of the runtime representation of a tag.
Can be a literal (case with no payload), or a block (case with payload).
Expand All @@ -89,6 +100,16 @@ type tag = {name: string; tag_type: tag_type option}
type block = {tag: tag; tag_name: string option; block_type: block_type option}
type switch_names = {consts: tag array; blocks: block array}

let tag_type_to_type_string = function
| String _ -> "string"
| Int _ -> "int"
| Float _ -> "float"
| BigInt _ -> "bigint"
| Bool _ -> "bool"
| Null -> "null"
| Undefined -> "undefined"
| Untagged block_type -> block_type_to_string block_type

let untagged = "unboxed"

let block_type_can_be_undefined = function
Expand Down
Loading
Loading