Recovery in completions #7410
Draft
Recovery in completions #7410
+168
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
commented
Apr 29, 2025
| @@ -1,20 +1,15 @@ | |||
| Found Completable: Cpattern | |||
| case _ vamp [4:2->6:1], has cursor true | |||
| Found Completable: Ccase | |||
There was a problem hiding this comment.
This is the whole point of the snapshot testing setup.
We can visually see that we are hooking onto a better ast node and can use this for completions.
zth
force-pushed
the
analysis-simplification
branch
from
b1518ea to
b11f460
Compare
|
Currently using the patternhole as found node in frontend completion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept to find a cursor inside broken code.
The idea is to have a second pass of the syntax tree after parsing.
There we can update certain location, which streamlines the frontend completion phase.