Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jfrolich, I found the problem for #7493
It turns out that my
package.json
name key was not exactly the same as what was used in myrescript.json
setup. Causing a mismatch incompile.rs
.So, my setup is:
project package.json
So, this gets installed as
node_modules/@nojaf/rescript-firebase
But
node_modules/@nojaf/rescript-firebase/package.json
had"name": "rescript-firebase"
.While
node_modules/@nojaf/rescript-firebase/rescript.json
had"name": "@nojaf/rescript-firebase"
.I would be okay with updating my own code. But this does seem like a restriction the previous build system didn't have. So, maybe updating the code (using
config.name.clone(),
) makes sense.I'm not sure.