Skip to content

Detect package name mismatch #7604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Jul 5, 2025

Hi @jfrolich, I found the problem for #7493

It turns out that my package.json name key was not exactly the same as what was used in my rescript.json setup. Causing a mismatch in compile.rs.

So, my setup is:
project package.json

  "devDependencies": {
    "@nojaf/rescript-firebase": "github:nojaf/rescript-firebase#56f74c3140f1a32d9ec8626930deb012d66e8c82",
}

So, this gets installed as node_modules/@nojaf/rescript-firebase
But node_modules/@nojaf/rescript-firebase/package.json had "name": "rescript-firebase".
While node_modules/@nojaf/rescript-firebase/rescript.json had "name": "@nojaf/rescript-firebase".

I would be okay with updating my own code. But this does seem like a restriction the previous build system didn't have. So, maybe updating the code (using config.name.clone(),) makes sense.

I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant